Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Change AppInsights to not add parameters more than once #3506

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 9, 2024

Backport of #3464 to release/8.0

/cc @mitchdenny @davidfowl

Customer Impact

Testing

Unit tests were added as part of this change to cover this scenario, so we don't regress it in the future.

Risk

Low risk. Code change is very minor in the runtime bits and it's a safe change - this just removes the potential for an exception.

Regression?

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 9, 2024
@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 9, 2024
@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danmoseley danmoseley closed this Apr 9, 2024
@danmoseley danmoseley reopened this Apr 9, 2024
@danmoseley danmoseley closed this Apr 9, 2024
@danmoseley danmoseley reopened this Apr 9, 2024
@danmoseley danmoseley merged commit c6266ef into release/8.0 Apr 9, 2024
9 checks passed
@danmoseley danmoseley deleted the backport/pr-3464-to-release/8.0 branch April 9, 2024 05:01
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants