[release/8.0] Change AppInsights to not add parameters more than once #3506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3464 to release/8.0
/cc @mitchdenny @davidfowl
Customer Impact
public static IResourceBuilder<AzureApplicationInsightsResource> AddAzureApplicationInsights
: Replaced theAdd
method with theTryAdd
method for adding theLogAnalyticsWorkspaceId
parameter to theResource
object. This change prevents potential exceptions if the parameter already exists in the dictionary.Testing
Unit tests were added as part of this change to cover this scenario, so we don't regress it in the future.
Risk
Low risk. Code change is very minor in the runtime bits and it's a safe change - this just removes the potential for an exception.
Regression?
Microsoft Reviewers: Open in CodeFlow