Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider cross-compiling projects to target DefaultNetCoreTargetFramework #25917

Closed
pranavkm opened this issue Sep 15, 2020 · 2 comments · Fixed by #31239
Closed

Consider cross-compiling projects to target DefaultNetCoreTargetFramework #25917

pranavkm opened this issue Sep 15, 2020 · 2 comments · Fixed by #31239
Assignees
Labels
affected-very-few This issue impacts very few customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework severity-nice-to-have This label is used by an internal tool task
Milestone

Comments

@pranavkm
Copy link
Contributor

We have a handful of projects in the repo that do not cross-compile to .NET Core. The reference assemblies in .NET Core carry nullability and platform compatibility annotations and there are currently no plans to make this work on down level tfms.

Updating these projects to additionally cross-compile to $(DefaultNetCoreTargetFramework) seems like a small cost for the richer compile time we gain:

@pranavkm pranavkm added feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform area-signalr Includes: SignalR clients and servers labels Sep 15, 2020
@BrennanConroy BrennanConroy added this to the Next sprint planning milestone Sep 16, 2020
@ghost
Copy link

ghost commented Sep 16, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@wtgodbe
Copy link
Member

wtgodbe commented Dec 23, 2020

@wtgodbe wtgodbe added affected-very-few This issue impacts very few customers severity-nice-to-have This label is used by an internal tool labels Dec 23, 2020
@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform labels Jan 28, 2021
@pranavkm pranavkm modified the milestones: 6.0-preview2, 6.0-preview4 Mar 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2021
@danroth27 danroth27 added the task label May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-very-few This issue impacts very few customers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework severity-nice-to-have This label is used by an internal tool task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants