-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md for project #27562
Comments
Hi @captainsafia, I am also thinking to update BuildFromSource.md to get it more consistent like others. See workflow guide at other repositories. What I think is like they are more verbose and also at runtime repo they are having separate instruction on building various part of repo. |
We are tackling this work as part of #27561.
We did some improvements on the BuildFromSource.md doc a while back. What kind of things should we copy from the runtime repo? For now, this issue is focused on updating the CONTRIBUTING.md to address parts of the contribution process that aren't directly related to the build. If there's more improvements we can make in BuildFromSource.md we can track those in a different issue. |
@captainsafia is there anything left here you think we should consider? |
@captainsafia what is left to be done here, if anything? I think we should close it, if there is nothing specific, as I know you had done a lot of work a while ago on improving our docs. |
I think we can go ahead and close this. |
Update CONTRIBUTING.md docs to explain our CI process, how to address common feedback from the CI, and how we review PRs.
The text was updated successfully, but these errors were encountered: