Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider shipping ASP.NET Core analyzers in targeting pack #31294

Closed
pranavkm opened this issue Mar 26, 2021 · 2 comments
Closed

Consider shipping ASP.NET Core analyzers in targeting pack #31294

pranavkm opened this issue Mar 26, 2021 · 2 comments
Assignees
Labels
analyzer Indicates an issue which is related to analyzer experience area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@pranavkm
Copy link
Contributor

As we plan on adding new analyzers in 6.0, one of the problems we'll run in to is that these changes would affect all ASP.NET Core apps targeting 3.1 onwards. We could do something special the analyzer to light up the new ones, but it seems like a better strategy to follow from the in-box source generator design recommends and ship this as part of a pack instead. We would freeze the current set of analyzers that ship as part of the SDK to be point in time and use the ones in the pack to target 6.0 and newer apps.

@pranavkm pranavkm added the analyzer Indicates an issue which is related to analyzer experience label Mar 26, 2021
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 29, 2021
@dougbu
Copy link
Member

dougbu commented Jun 7, 2021

At least for now, assigning to @pranavkm because we (the build v-team) are not likely to drive this product change. We are available to provide guidance as needed.

/cc @mkArtakMSFT

@pranavkm
Copy link
Contributor Author

Closing this as we don't have any plans to change things here at this point.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
analyzer Indicates an issue which is related to analyzer experience area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

3 participants