Static logging delegates nested inside generic types

[JamesNK]

Static logging delegates will allocate a new copy for each generic type.

See #31333 (comment)

Should audit for all usages of static logging delegates to see if there are other places they are nested in generic types.

Before:

// RequestContext.Log.cs
internal sealed partial class RequestContext<TContext>
{
    private static class Log { }
}

After:

// RequestContext.Log.cs
internal static class RequestContext
{
    private static class Log { }
}

Edit: That won't work because Log will be private. How about internal static class RequestContextLog with no nested Log type.

[andrzejpindor]

Happy to pick this up - in #31345 I've already refactored RequestContext<T> but I can also check other places where situation may be similar.

[martincostello]

Other than the two already mentioned in #31333, I also found these two which I can fix up at the same time:

aspnetcore/src/SignalR/server/Core/src/HubConnectionHandler.cs

Line 23 in c0d17cf

public class HubConnectionHandler<THub> : ConnectionHandler where THub : Hub

aspnetcore/src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.Log.cs

Lines 11 to 13 in c0d17cf

	internal partial class DefaultHubDispatcher<THub>
	{
	private static class Log

[martincostello]

Oh - I see you've already done it in #31345 - I was already in the middle of doing it from this comment #31333 (comment), but happy for you to do it instead.

[andrzejpindor]

I can also cover the two cases mentioned by you and scan project for similar problems. I'll wait to become an assignee to this issue to continue work ;)

[martincostello]

I did a search in VS Code across the whole ASP.NET Core solution for private static class Log and those were the only other two I could find that were inside a generic type.

I hadn't started on changing those two yet, so feel free to make the change yourself 🙂

[jkotalik]

Feel free to pick up the ones in SignalR as well.

[BrennanConroy]

Done via #31364