Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Razor component' versus 'Blazor component' in project templates #31559

Closed
guardrex opened this issue Apr 6, 2021 · 4 comments · Fixed by #31590
Closed

'Razor component' versus 'Blazor component' in project templates #31559

guardrex opened this issue Apr 6, 2021 · 4 comments · Fixed by #31590
Labels
area-blazor Includes: Blazor, Razor Components good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue
Milestone

Comments

@guardrex
Copy link
Contributor

guardrex commented Apr 6, 2021

Is your feature request related to a problem? Please describe.

Feature description question

Describe the solution you'd like

The RCL project template and the WebView sample component have a components with the following markup:

<div class="my-component">
    This Blazor component is defined in the <strong>WebviewAppShared</strong> package.
</div>
<div class="my-component">
    This Blazor component is defined in the <strong>Company.RazorClassLibrary1</strong> library.
</div>

We don't currently use the naming 'Blazor component' in docs. We use 'Razor component' everywhere. I wonder if these framework components should use 'Razor component'? If not, what doc contexts should use 'Blazor component'?

Additional context

Also note that a few other spots use 'Blazor component' lingo. For example, I saw 'Blazor component model' go by in search results.

@javiercn javiercn added the area-blazor Includes: Blazor, Razor Components label Apr 6, 2021
@javiercn
Copy link
Member

javiercn commented Apr 6, 2021

@guardrex thanks for bringing this up.

These should be renamed to razor component

@javiercn javiercn added good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue labels Apr 6, 2021
@pranavkm
Copy link
Contributor

pranavkm commented Apr 6, 2021

Could we rename this to "This component" (so we don't use either Blazor or Razor) here?

@pranavkm pranavkm added this to the Next sprint planning milestone Apr 6, 2021
@ghost
Copy link

ghost commented Apr 6, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@adrianwright109
Copy link
Contributor

I would like to take this on and create a PR - is that OK ?

@ghost ghost closed this as completed in #31590 Apr 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components good first issue Good for newcomers. help wanted Up for grabs. We would accept a PR to help resolve this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants