Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razor VSCode ? commit char conflicts with ?? Null Coalescing Operator #4675

Closed
TanayParikh opened this issue Sep 21, 2021 · 2 comments
Closed
Milestone

Comments

@TanayParikh
Copy link
Contributor

I was trying to write ?? but after the first ?, it interpreted the second ? as a completion commit char, yielding ?{COMPLETION_ITEM}?

O# in a C# file seems to exclude ? from being a completion trigger char, perhaps razor may want to do the same?

Screen.Recording.2021-09-21.at.2.47.55.PM.mov
@TanayParikh
Copy link
Contributor Author

O# in a C# file seems to exclude ? from being a completion trigger char, perhaps razor may want to do the same?

https://github.com/dotnet/aspnetcore-tooling/blob/ddaa8903e03538fbffcda72169c29df1e18cf74f/src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/HtmlCSharp/CompletionHandler.cs#L25

Hmm looks like it's already excluded.

@NTaylorMullen
Copy link
Contributor

@TanayParikh looks like this is an O# roslyn thing. They shoiuld not be providing a ? commit character at that location. Would you mind moving?

@allisonchou allisonchou transferred this issue from dotnet/aspnetcore Oct 8, 2021
@allisonchou allisonchou added this to the 17.0-Preview5 milestone Oct 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants