Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming standard for private static fields #50888

Open
JamesNK opened this issue Sep 23, 2023 · 3 comments · May be fixed by #56647
Open

Consistent naming standard for private static fields #50888

JamesNK opened this issue Sep 23, 2023 · 3 comments · May be fixed by #56647
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team

Comments

@JamesNK
Copy link
Member

JamesNK commented Sep 23, 2023

dotnet/aspnetcore mixes _underscore and PascalCase for private static fields. We should pick one for consistency and enable a naming rule to enforce it.

Search results: https://github.com/search?q=repo%3Adotnet%2Faspnetcore%20%22private%20static%20readonly%22&type=code

Note: dotnet/runtime uses s_ prefix.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Sep 23, 2023
@gfoidl gfoidl added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed area-blazor Includes: Blazor, Razor Components labels Sep 23, 2023
@mkArtakMSFT
Copy link
Member

Potentially related then #50854.
Is there more work to be done here, @JamesNK ?

@mkArtakMSFT mkArtakMSFT added this to the .NET 9 Planning milestone Sep 26, 2023
@ghost
Copy link

ghost commented Sep 26, 2023

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@JamesNK
Copy link
Member Author

JamesNK commented Sep 27, 2023

Potentially related then #50854. Is there more work to be done here, @JamesNK ?

That PR doesn't have a rule for private static fields.

@Kahbazi Kahbazi added the help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team label Nov 4, 2023
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework help candidate Indicates that the issues may be a good fit for community to help with. Requires work from eng. team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants