Fix typos #56530
Merged
Fix typos #56530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
dotnet-policy-service
bot
added
the
pending-ci-rerun
martincostello
removed
the
pending-ci-rerun
adityamandaleeka
approved these changes
Jul 8, 2024
|
Can you try rebasing on main @martincostello? The test failure is clearly unrelated and I wonder if it's something that was already fixed. |
|
cc @amcasey |
I don't recognize the failure and it also doesn't make much sense to me - it looks like the "missing" DLL was written earlier in the build. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
3 tasks
|
Rebased. |
|
Looks like now it ran into #53294. I wonder if we should disable that test. |
|
Trying one more run. If it fails again due to an unrelated reason, I'm okay with merging this on red. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos
Fix some test and comment typos.
Description
Spotted a typo in a test name, which lead me to the others: