Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK zip not found when running .\eng\scripts\InstallJdk.ps1 #58457

Closed
ShreyasJejurkar opened this issue Oct 16, 2024 · 3 comments
Closed

JDK zip not found when running .\eng\scripts\InstallJdk.ps1 #58457

ShreyasJejurkar opened this issue Oct 16, 2024 · 3 comments
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@ShreyasJejurkar
Copy link
Contributor

Trying to build all repos on my new machine by referring https://github.com/dotnet/aspnetcore/blob/main/docs/BuildFromSource.md. I found that I don't have JDK installed, so tried to install it with the script in the scripts folder, but getting the below error. Looks like the resource is not on the server.

Image

Looks like we need to update this, or maybe if we can detect we are on windows (which we can I guess) we can use Winget to install JDK instead of relying on this. It will be simple and less error prone.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 16, 2024
@amcasey
Copy link
Member

amcasey commented Oct 17, 2024

I think @adityamandaleeka may have looked at this recently?

@BrennanConroy
Copy link
Member

BrennanConroy commented Oct 21, 2024

This should be working now. The global.json was using "11", which is another way of saying "use latest version of 11", but it only works for some tooling. Now the global.json is "11.0.24" which should work with the installjdk script.

Edit: Nevermind, the script is still broken, it gets a little further though...

Edit edit: Now it should work.

@wtgodbe
Copy link
Member

wtgodbe commented Oct 22, 2024

Fixed by #58557. Feel free to re-open if you're still having issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

4 participants