Fix VS crash with malformed tag helpers #26779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
ajaybhargavb
commented
Oct 10, 2020
| { | ||
| return false; | ||
| } | ||
|
|
||
| // Validate that our end tag matches the currently scoped tag, if not we may need to error. | ||
| if (tagNameScope.Equals(tagName, StringComparison.OrdinalIgnoreCase)) | ||
| if (startTag != null && tagNameScope.Equals(tagName, StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
This is the actual fix. Everything else is just a bunch of renames.
This was referenced Oct 13, 2020
ajaybhargavb
added a commit
that referenced
this pull request
Oct 13, 2020
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1226741
Example,
Consider the above example. In this case, the parser groups the start/end tags correctly (i.e. the
</a>in the middle has no start tag).But in the tag helper rewriting phase, we end up incorrectly identifying the middle
</a>as the end tag for the start tag and pop the stack causing it to throw when it reaches the final</a>tag.The fix: In addition to checking if the tag name matches, pop the stack only when there is a corresponding start tag available.