Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of Microsoft.Identity.Web and Microsoft.Identity.Web.UI to 2.7.0 #47906

Merged
merged 18 commits into from
May 17, 2023

Conversation

surayya-MS
Copy link
Member

@surayya-MS surayya-MS commented Apr 26, 2023

Update version of Microsoft.Identity.Web and Microsoft.Identity.Web.UI to 2.7.0

Fixes #47823

@surayya-MS surayya-MS requested review from a team and wtgodbe as code owners April 26, 2023 15:21
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-identity Includes: Identity and providers label Apr 26, 2023
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 26, 2023
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the transition across the major version is smooth, LGTM

@amcasey
Copy link
Member

amcasey commented Apr 28, 2023

I see build failures because of ObsoleteAttribute, probably related to the major version bump. Is there a minor version that meets our needs?

@ghost
Copy link

ghost commented May 6, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label May 6, 2023
@surayya-MS
Copy link
Member Author

surayya-MS commented May 10, 2023

I see build failures because of ObsoleteAttribute, probably related to the major version bump. Is there a minor version that meets our needs?

@mkArtakMSFT , @halter73 should we update to the latest version (just checked it is 2.10.0) and deal with breaking changes or update to a minor version that doesn't create checks failures?

@surayya-MS surayya-MS requested a review from a team as a code owner May 11, 2023 17:24
@surayya-MS
Copy link
Member Author

surayya-MS commented May 11, 2023

Migration docs aka.ms/id-web-downstream-api-v2

Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/dnceng It looks like https://www.nuget.org/packages/Microsoft.Identity.Web.DownstreamApi is not in our dotnet-public feed. How do we go about adding it?

Co-authored-by: Stephen Halter <halter73@gmail.com>
@wtgodbe
Copy link
Member

wtgodbe commented May 12, 2023

It looks like https://www.nuget.org/packages/Microsoft.Identity.Web.DownstreamApi is not in our dotnet-public feed. How do we go about adding it?

https://github.com/dotnet/arcade/blob/main/Documentation/MirroringPackages.md

@surayya-MS surayya-MS requested a review from halter73 May 15, 2023 16:33
@surayya-MS surayya-MS merged commit 0a1469a into dotnet:main May 17, 2023
@surayya-MS surayya-MS deleted the updateIdentityPackages branch May 17, 2023 08:39
@ghost ghost added this to the 8.0-preview5 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Older versions of nuget packages for Blazor Webassembly hosted project
4 participants