Set up Windows installer build for the VMR #58820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for only building the current vertical's installers (and building the hosting bundle in pass 2) when building aspnetcore in the VMR.
… for the VMR just like we have for dotnet/sdk
dotnet-issue-labeler
bot
added
the
area-infrastructure
jkoritzinsky
added a commit
to jkoritzinsky/dotnet-sdk
that referenced
this pull request
Nov 6, 2024
…s from the local artifacts assets path Required to consume dotnet/aspnetcore#58820 in the VMR
ViktorHofer
reviewed
Nov 7, 2024
ViktorHofer
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for only building the current vertical's installers in pass 1 (and building the hosting bundle in pass 2) when building aspnetcore in the VMR.
Also, change how we download "known" assets to use the same mechanism as dotnet/sdk so the VMR can point to local artifacts.
This PR will require a reactive change in the VMR that adds https://github.com/dotnet/sdk/blob/b5a9089d86579d5a0f600478634db4ac1044cc75/src/SourceBuild/content/repo-projects/sdk.proj#L37 to the
aspnetcore.projproject (which I'll prep now).This should set up enough infra that we can turn on building installers on Windows for aspnetcore in the VMR and that (I hope) most if not all changes required for the hosting bundle can be done within the VMR.
Contributes to dotnet/source-build#4692 (Windows)