Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate does not include transitive frameworkAssemblies #7079

Closed
NTaylorMullen opened this issue Nov 2, 2016 · 0 comments
Closed

Migrate does not include transitive frameworkAssemblies #7079

NTaylorMullen opened this issue Nov 2, 2016 · 0 comments

Comments

@NTaylorMullen
Copy link
Contributor

Including transitive frameworkAssemblies may make a migrated csproj unmanageable due to how many framework assemblies may need to be included; however, without it users projects may successfully migrate but then fail to build.

Note, once this is fixed this issue should go away; however, that's not slated until after RC. We've worked around this already for migrated project references but have not done it for frameworkAssemblies.

Steps to reproduce

Expected behavior

  • Project1 has a reference node for System.ComponentModel.DataAnnotations.

Actual behavior

  • No reference node for System.ComponentModel.DataAnnotations.

Environment data

dotnet --info output:

.NET Command Line Tools (1.0.0-preview3-004007)

Product Information:
 Version:            1.0.0-preview3-004007
 Commit SHA-1 hash:  80ec02b4da

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64

/cc @DamianEdwards @livarcocc

@livarcocc livarcocc self-assigned this Nov 3, 2016
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-preview4 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants