Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: https://github.com/aspnet/Mvc #7553

Closed
jgoshi opened this issue Jan 18, 2017 · 1 comment
Closed

Migration: https://github.com/aspnet/Mvc #7553

jgoshi opened this issue Jan 18, 2017 · 1 comment
Assignees
@livarcocc
Labels
release blocking
Milestone
1.0.0-rtm

Comments

@jgoshi
Copy link
Contributor

jgoshi commented Jan 18, 2017

  1. Go to https://github.com/aspnet/Mvc
  2. Download as zip
  3. dotnet migrate mvc.sln
  4. dotnet restore mvc.sln
  5. dotnet build mvc.sln

There are many build errors and I haven't been able to track down the root causes yet.
@livarcocc livarcocc self-assigned this Jan 30, 2017
@livarcocc
Copy link
Contributor

I tried this migration. As far as I can see I hit two known issues here:

  1. dotnet restore does not capture transitive framework assemblies from project references NuGet/Home#4412
  2. https://github.com/dotnet/cli/issues/5318

After adding a reference to ViewFeatures to DataAnnotations, I managed to build all projects under src.
Tests continued to fail as I am not sure what I should put in place of the Shared that is causing all tests to fail.

However, given that the issues I have are other known issues, I am closing this one.

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@livarcocc livarcocc

Labels
release blocking
Projects
None yet
Milestone
1.0.0-rtm
Development

No branches or pull requests
3 participants
@livarcocc @msftgits @jgoshi