Accessing resource strings from external assembly always returns default strings instead of string based on culture info.

[mailfcly]

Issue Title

Accessing resource strings from external assembly always returns default strings instead of string based on culture info.

Code in ClassLibrary2.dll

• add Resources.resx
• add Resources.en.resx

       public void OutputText()
        {
            CultureInfo ci = CultureInfo.CreateSpecificCulture("en-US");
            Properties.Resources.Culture = ci;

            Console.WriteLine(Properties.Resources.String1);
        }

Code in MainApp.exe

            var assembly = Assembly.LoadFrom(@"C:\D\tmp\ConsoleApp1\ClassLibrary2\bin\Debug\netcoreapp2.1\ClassLibrary2.dll");

            foreach(var type in assembly.GetTypes())
            {
                if(type.FullName.Contains("ClassLibrary2.Class1"))
                {
                    var itemList = Activator.CreateInstance(type) as ClassLibrary1.IClass1;
                    itemList.OutputText();
                }
            }

Expected result

output text from Resources.en.resx

Actual result

output text from Resources.resx

[karelz]

@tarekgh is it known issue? Can you please help me route it? Thanks!

[tarekgh]

@mailfcly could you send more info how did you build the assemblies and what framework and version you are targeting?

could you please share a small project repro this?

[tarekgh]

CC @sdmaclea

@mailfcly are you using net core in your project? I just want to confirm.

If this is the case, @jeffschwMSFT mentioned, satellite assemblies will not be found with LoadFrom... you need to subscribe to the resolve event to find them.

[mailfcly]

build with
Visual Studio 2017 15.8.7
.NET Core 2.1

my code:
ConsoleApp1.zip

[tarekgh]

@sdmaclea I assigned this one to you. could you please have a look why the satellite assembly didn't get loaded?

[tarekgh]

Sorry, I meant to assign it to @sdmaclea

[karelz]

@sdmaclea should we move the bug to CoreCLR? I see you have a fix there ...

[sdmaclea]

I opened dotnet/coreclr#20979 to address this inconvenience.

I will post a work-around here then close this issue.

[sdmaclea]

@mailfcly The current releases require adding a resolve handler. As mentioned above. This is sample code that worked for me based on @jeffschwMSFT's suggestion.

namespace ConsoleApp1
{
    class Program
    {
        static void Main(string[] args)
        {
            AppDomain.CurrentDomain.AssemblyResolve += new ResolveEventHandler(AssemblyResolveEventHandler);

            var assembly = Assembly.LoadFile(@"C:\Users\stmaclea\issues\2041\ConsoleApp1\ConsoleApp1\ClassLibrary2\bin\Debug\netcoreapp2.1\ClassLibrary2.dll");
            var a = assembly.GetManifestResourceNames();

            foreach(var type in assembly.GetTypes())
            {
                if(type.FullName.Contains("ClassLibrary2.Class1"))
                {
                    var itemList = Activator.CreateInstance(type) as ClassLibrary1.IClass1;
                    itemList.OutputText();
                }
            }
        }

        static System.Reflection.Assembly AssemblyResolveEventHandler(object sender, ResolveEventArgs args)
        {
            if (args.Name == "ClassLibrary2.resources, Version=1.0.0.0, Culture=en, PublicKeyToken=null")
            {
                return Assembly.LoadFile(@"C:\Users\stmaclea\issues\2041\ConsoleApp1\ConsoleApp1\ClassLibrary2\bin\Debug\netcoreapp2.1\en\ClassLibrary2.resources.dll");
            }

            return null;
        }
    }
}

This issue belongs in the coreclr repo. Closing here as dotnet/coreclr#20979 is opened to address the long term fix.