Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Add arm64 floatconversion.S #25597

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Add arm64 floatconversion.S #25597

merged 2 commits into from
Jul 8, 2019

Conversation

sdmaclea
Copy link

@sdmaclea sdmaclea commented Jul 8, 2019

Fixes #25575

@sdmaclea sdmaclea self-assigned this Jul 8, 2019
@sdmaclea sdmaclea requested review from chsienki, hoyosjs and tommcdon July 8, 2019 19:20
@sdmaclea sdmaclea added this to the 3.0 milestone Jul 8, 2019
hoyosjs
hoyosjs approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing validation now. However, I wonder, if the registers are 128 bits, is there any chance we report a bogus value? I think it should be fine but just wanted to confirm

src/debug/di/arm64/floatconversion.S Outdated Show resolved Hide resolved
@sdmaclea
Copy link
Author

sdmaclea commented Jul 8, 2019 •
edited
Loading

This is the same code as used in Windows arm64. It is just a port from asm to S assembly syntax

@sdmaclea sdmaclea merged commit 8749c01 into dotnet:master Jul 8, 2019
@sdmaclea sdmaclea deleted the floatconversion branch July 8, 2019 21:36
@sdmaclea sdmaclea mentioned this pull request Jan 31, 2020
Closed
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@sdmaclea
Add arm64 floatconversion.S (dotnet/coreclr#25597)
4f2bed7 
* Add arm64 floatconversion.S

* Update comment


Commit migrated from dotnet/coreclr@8749c01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@chsienki chsienki Awaiting requested review from chsienki

@tommcdon tommcdon Awaiting requested review from tommcdon

Assignees

@sdmaclea sdmaclea

Labels
arch-arm64 area-Diagnostics
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

[Linux ARM64] Step controls causes debugger to crash
2 participants
@sdmaclea @hoyosjs