alpine build should be built with /p:PortableBuild=true

[eerhardt]

This issue spans both dotnet/corefx and dotnet/coreclr.

In order to support our runtime on musl-based distros that are not alpine, we should be building our runtime with /p:PortableBuild=true. This will enable loading the correct libicu and libssl that are on the distro.

See

• https://github.com/dotnet/corefx/blob/master/buildpipeline/pipeline.json#L52
• https://github.com/dotnet/coreclr/blob/master/buildpipeline/pipelines.json#L50

This is a follow up to: https://github.com/dotnet/core-setup/issues/3817

[janvorli]

@eerhardt I've found that we don't need to do anything for coreclr. We always build it as ICU version agnostic with dynamic lookup at runtime. And passing the '-portable' option would cause the build to produce linux-x64 named packages.
In corefx, the PortableBuild property also induces a portable runtime to be used for corefx tests (restored into /home/janvorli/git/corefx/bin/testhost/...). That is a problem.

So it seems that until we have real end to end support for musl-linux RID, we should just modify the src/Native/build-native.sh to pass -DFEATURE_DISTRO_AGNOSTIC_SSL=1 to CMake for Alpine.

[janvorli]

@eerhardt so I've found that we already build the native corefx stuff with -portable flag in our official build:

Running: /root/corefx-1529936/src/Native/build-native.sh --RuntimeOS=alpine.3.6 --OfficialBuildId=20180328-06 x64 Release Linux --numproc 4 -portable stripSymbols toolSetDir=c:\tools\clr /p:PortableBuild=false /p:StabilizePackageVersion=false /p:PackageVersionStamp=

That means that we don't need to do anything now.

[danmoseley]

Can this be closed / moved to future then?

[ghost]

@janvorli, now that we have linux-musl-x64 RID, can we update the package names so we get dotnet-sdk-2.1.2-linux-musl-x64.tar.gz instead of dotnet-sdk-2.1.2-alpine.3.6-x64.tar.gz. This will support now-latest version of Alpine -> 3.7 as well as other musl-libc based linuxes. This will also align it with glibc based linux distors (for which we have dotnet-sdk-2.1.2-linux-x64.tar.gz).

[eerhardt]

/cc @weshaggard. I believe Wes is going to be updating the package names.