New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential race condition in SqlConnectionString.cs #26606

Closed

jkotas opened this issue Jun 25, 2018 · 1 comment · Fixed by dotnet/corefx#35344

Labels

area-System.Data.SqlClient

Milestone

Member

jkotas commented Jun 25, 2018

From dotnet/coreclr#17076

https://github.com/dotnet/corefx/blob/619dbe6503a2de2afa27122cb34716d9ff6906ff/src/System.Data.SqlClient/src/System/Data/SqlClient/SqlConnectionString.cs#L488-L492. cc: @saurabh500. There's no synchronization whatsoever (no locks, no interlockeds, no volatiles, etc.) used in lazily initializing this dictionary. It's possible that could be an issue on some hardware.

Contributor

saurabh500 commented Jun 25, 2018

@jkotas I agree. cc @keeratsingh @David-Engel for triage.

AfsanehR-zz closed this as completed in dotnet/corefx#35344

msftgits transferred this issue from dotnet/corefx

msftgits added this to the 3.0 milestone

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.