Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref for folders that are missing one #27762

Open
danmoseley opened this issue Oct 29, 2018 · 1 comment
Open

Add ref for folders that are missing one #27762

danmoseley opened this issue Oct 29, 2018 · 1 comment
Labels
area-Meta enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@danmoseley
Copy link
Member

danmoseley commented Oct 29, 2018

Some libraries in corefx have a src folder but no ref folder. In this case the src surface area will be used directly as the ref. This has some disadvantages such as

  1. Ref folder is nice for quickly looking at the surface area and its history
  2. Ref reduces the size of the references package
  3. Possibly a build race, per Figure out build process for libraries with no reference assembly #19584.

We should be consistent and have a ref folder. We already did a pass in #19584. We should do that again and this time ideally add a build step so that new libraries must have one.

These look like they need a ref:

System.Composition
System.Composition.AttributedModel
System.Composition.Convention
System.Composition.Hosting
System.Composition.Runtime
System.Composition.TypedParts
System.Text.Encodings.Web

These do not have one but I believe they produce code that is in a ref in another project (might need special casing in the build step)

System.Private.DataContractSerialization
System.Private.Reflection.Metadata.Ecma335
System.Private.Uri
System.Private.Xml
System.Private.Xml.Linq

Not sure about these, I assume not

Microsoft.Diagnostics.Tracing.EventSource.Redist
Microsoft.IO.Redist
Microsoft.XmlSerializer.Generator

cc @ericstj @weshaggard

@ViktorHofer
Copy link
Member

I think the extra build step isn't necessary here as I would be surprised if we allow new libraries without refs in PR reviews. I think the remaining work is to just create the refs for the mentioned projects. Will move the label to enhancement as I don't see any infra work necessarily to be done.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta enhancement Product code improvement that does NOT require public API changes/additions
Projects
No open projects
Development

No branches or pull requests

5 participants