Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUtility.UrlDecode to take StringBuilder #16290

Closed
benaadams opened this issue Feb 4, 2016 · 3 comments
Closed

WebUtility.UrlDecode to take StringBuilder #16290

benaadams opened this issue Feb 4, 2016 · 3 comments
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.Net help wanted [up-for-grabs] Good issue for external contributors
Milestone
3.0

Comments

@benaadams
Copy link
Member

WebUtility.UrlDecode could take a string builder; UrlDecoder could be a struct and use System.Buffers for its arrays for reduced allocations.
@SidharthNabar SidharthNabar removed their assignment Feb 18, 2016
@jamesqo
Copy link
Contributor

jamesqo commented Mar 1, 2016

@davidsh Shouldn't this be labeled as an API addition, since it's adding a new public method to a class?

@davidsh
Copy link
Contributor

davidsh commented Mar 1, 2016

It is labeled ok right now. Yes, though, in order to move forward with this issue, a properly filed api addition issue must be generated along with design thoughts on how with would align with .NET Framework existing API patterns.

@davidsh davidsh removed their assignment Nov 18, 2016
@davidsh
Copy link
Contributor

davidsh commented May 5, 2018

Span, for example, is the new efficient way to pass in these kind of string types instead of StringBuilder. So, closing this issue. If there are new API proposals that would benefit from using Span in the WebUtility class, then please open a new API proposal issue.

@davidsh davidsh closed this as completed May 5, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.Net help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
5 participants
@benaadams @davidsh @jamesqo @msftgits @SidharthNabar