-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert System.Runtime.InteropServices.RuntimeInformation to a fat package #17035
Comments
Another thing I'm noticing while looking at this is some packages have a specific desktop asset and RID specific assets but don't always put the desktop asset in the RID folder. As a result we could get different implementation (wrong) when resolving for desktop and providing a rid like "win7" or "win8". I think we should try and make all the desktop assets behave the same. If the package is fat, duplicate the desktop asset in the RID and RID-less folder. |
/cc @emgarten This is interesting because it means you can end up with different nuget selection on |
Yeah, that's expected. I'm making changes to our packages to ensure that any packages that do support project-types that are still on packages.config get the same asset (by copying that asset into lib, so long as it doesn't require RID specific selection on those projects) |
@ericstj - is this not going to be fixed for RTM? |
It's already fixed in the RC3 packages. |
Ok. I was confused by the 1.1.0 milestone attached to this work item. |
That's odd, it was set to 1.0.0-rtm on 28 days ago, and I don't see anything that changed it to 1.1.0. I have changed it back. |
This enables us to package it such that it works on desktop without a lineup. Desktop shouldn't need a lineup and this is one package that was causing it to be required. Let's double check all packages as part of this work to ensure they don't need a lineup for desktop.
The text was updated successfully, but these errors were encountered: