Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Support musl-libc based linux RIDs #28560

Merged
merged 3 commits into from
Mar 30, 2018
Merged

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Mar 28, 2018

  • Add linux-musl RID
  • Set alpine's parent to linux-musl
  • Add alpine.3.7 to the graph
  • Fix up android to inherit from unix while we are here

Fixes https://github.com/dotnet/core-setup/issues/3817

QUESTION: Is linux-musl the correct name for this RID? Do we like the order of the two words? Is using a hyphen to separate them acceptable?

/cc @Petermarcu

@eerhardt eerhardt requested review from ericstj and janvorli March 28, 2018 19:49
@Petermarcu
Copy link
Member

lgtm

@janvorli
Copy link
Member

Is musl-linux the correct name for this RID? Do we like the order of the two words? Is using a hyphen to separate them acceptable?

This name format makes sense, I only wonder if parsing of RID that we may have at various places would work correctly without changes.

@danmoseley
Copy link
Member

@weshaggard for question about RID parsing.

@eerhardt
Copy link
Member Author

test Linux x64 Release Build
test OSX x64 Debug Build

Both System.Net.HttpListener test failures

@weshaggard
Copy link
Member

This name format makes sense, I only wonder if parsing of RID that we may have at various places would work correctly without changes.

It should work as far as I'm aware. @steveharter are you aware of anything in the host parsing code that wouldn't handle this naming convention?

@4creators
Copy link
Contributor

4creators commented Mar 28, 2018

IMO as linux is more general term and musl is just a C runtime linux-musl could be better.

@steveharter
Copy link
Member

@steveharter are you aware of anything in the host parsing code that wouldn't handle this naming convention?

I am not aware of any parsing code like that. The host really depends on the "fallback graph" in NETCoreApp's runtimeconfig.json to define the list of RIDs and their fallback RIDs.

@eerhardt
Copy link
Member Author

- Add `linux-musl` RID
- Set `alpine`'s parent to `linux-musl`
- Add `alpine.3.7` to the graph
- Fix up `android` to inherit from `unix` while we are here

Fixes https://github.com/dotnet/core-setup/issues/3817
@eerhardt
Copy link
Member Author

I've renamed the RID to linux-musl. I agree it makes sense to have the more general term first.

@eerhardt
Copy link
Member Author

I've updated linux-musl's parent to be linux based on this discussion: https://github.com/dotnet/core-setup/issues/3817#issuecomment-377328964

@eerhardt
Copy link
Member Author

Can someone review this? I'd like to get it in for ZBB tomorrow.

@eerhardt eerhardt merged commit 81ba628 into dotnet:master Mar 30, 2018
@eerhardt eerhardt deleted the FixAlpineRID branch March 30, 2018 13:14
@karelz karelz added this to the 2.1.0 milestone Apr 2, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Support musl-libc based linux RIDs

- Add `linux-musl` RID
- Set `alpine`'s parent to `linux-musl`
- Add `alpine.3.7` to the graph
- Fix up `android` to inherit from `unix` while we are here

Fixes https://github.com/dotnet/core-setup/issues/3817

* Change linux-musl to be parented to linux.

* Reparent android RID to linux.


Commit migrated from dotnet/corefx@81ba628
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants