-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Conversation
lgtm |
This name format makes sense, I only wonder if parsing of RID that we may have at various places would work correctly without changes. |
@weshaggard for question about RID parsing. |
test Linux x64 Release Build Both System.Net.HttpListener test failures |
It should work as far as I'm aware. @steveharter are you aware of anything in the host parsing code that wouldn't handle this naming convention? |
IMO as linux is more general term and musl is just a C runtime |
I am not aware of any parsing code like that. The host really depends on the "fallback graph" in NETCoreApp's runtimeconfig.json to define the list of RIDs and their fallback RIDs. |
@4creators - we had the opposite opinion from @kasper3 on https://github.com/dotnet/core-setup/issues/3817#issuecomment-376773300. |
- Add `linux-musl` RID - Set `alpine`'s parent to `linux-musl` - Add `alpine.3.7` to the graph - Fix up `android` to inherit from `unix` while we are here Fixes https://github.com/dotnet/core-setup/issues/3817
I've renamed the RID to |
I've updated |
Can someone review this? I'd like to get it in for ZBB tomorrow. |
* Support musl-libc based linux RIDs - Add `linux-musl` RID - Set `alpine`'s parent to `linux-musl` - Add `alpine.3.7` to the graph - Fix up `android` to inherit from `unix` while we are here Fixes https://github.com/dotnet/core-setup/issues/3817 * Change linux-musl to be parented to linux. * Reparent android RID to linux. Commit migrated from dotnet/corefx@81ba628
linux-musl
RIDalpine
's parent tolinux-musl
alpine.3.7
to the graphandroid
to inherit fromunix
while we are hereFixes https://github.com/dotnet/core-setup/issues/3817
QUESTION: Is
linux-musl
the correct name for this RID? Do we like the order of the two words? Is using a hyphen to separate them acceptable?/cc @Petermarcu