Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New article]: WaitFor/WaitForCompletion docs #1556

Closed
mitchdenny opened this issue Aug 23, 2024 · 3 comments · Fixed by #1867
Closed

[New article]: WaitFor/WaitForCompletion docs #1556

mitchdenny opened this issue Aug 23, 2024 · 3 comments · Fixed by #1867
Assignees
Labels
doc-idea Indicates issues that are suggestions for new topics [org][type][category] documentation Improvements or additions to documentation dotnet-aspire/prod fundamentals Content related to fundamentals. in-pr okr-freshness OKR: Freshness of content Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. 📦 release-9.0 Used to track doc updates for release 9.0 of .NET Aspire.
Milestone

Comments

@mitchdenny
Copy link
Member

mitchdenny commented Aug 23, 2024

Proposed topic or title

Controlling service startup

Location in table of contents.

No response

Reason for the article

We are introducing WaitFor and WaitForCompletion APIs in .NET Aspire 9.0 which will allow resource startup to be controlled for local development. This will also integrate with a health check mechanism for resources which runs within the app host.

Article abstract

The article would take a simple application that uses a database and has two services (front-end and backend) and talk through what could happen when starting all these projects locally. Issues like the database not be initialized (writing a console app to initialize the database and using the WaitForCompletion API) and waiting for dependent services to start.

Relevant searches

No response


Associated WorkItem - 308088

@mitchdenny mitchdenny added the doc-idea Indicates issues that are suggestions for new topics [org][type][category] label Aug 23, 2024
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Aug 23, 2024
@IEvangelist IEvangelist added the 📦 release-9.0 Used to track doc updates for release 9.0 of .NET Aspire. label Aug 26, 2024
@IEvangelist IEvangelist self-assigned this Sep 3, 2024
@IEvangelist IEvangelist added documentation Improvements or additions to documentation 🗺️ reQUEST Triggers an issue to be imported into Quest. Pri1 High priority, do before Pri2 and Pri3 fundamentals Content related to fundamentals. dotnet-aspire/prod okr-freshness OKR: Freshness of content labels Sep 4, 2024
@dotnet-bot dotnet-bot removed ⌚ Not Triaged Not triaged labels Sep 4, 2024
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Sep 4, 2024
@afscrome
Copy link

afscrome commented Sep 9, 2024

Not sure if it should go into this article, or be a separate related article but it would be helpful to document some of the errors that you get if you don't use WatiFor. e.g. if you try to connect to SQL before it's ready, you'll get the following error

Microsoft.Data.SqlClient.SqlException (0x80131904): A connection was successfully established with the server, but then an error occurred during the pre-login handshake. (provider: TCP Provider, error: 0 - 20)

The idea would be that if someone gets this error (or similar errors for other components) and puts it into a search engine, there should be a good chance that the WaitFor docs appear with how to solve the issue.

@dotnetrepoman dotnetrepoman bot added 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. and removed 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. labels Oct 1, 2024
@afscrome
Copy link

afscrome commented Oct 6, 2024

Another thing to watch out for when documenting this - docs already have sections for client integrations health checks - e.g. https://learn.microsoft.com/en-us/dotnet/aspire/database/sql-server-integration?tabs=dotnet-cli#health-checks

Need to be make sure to clearly distinguish between the app host health checks and the client health checks.

@davidfowl
Copy link
Member

We’re revamping integration docs. They haven’t been updated yet.

We’re currently starting with rabbitmq

#1759

@IEvangelist IEvangelist added this to the 9.0 milestone Oct 21, 2024
@dotnetrepoman dotnetrepoman bot added 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. and removed 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-idea Indicates issues that are suggestions for new topics [org][type][category] documentation Improvements or additions to documentation dotnet-aspire/prod fundamentals Content related to fundamentals. in-pr okr-freshness OKR: Freshness of content Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. 📦 release-9.0 Used to track doc updates for release 9.0 of .NET Aspire.
Projects
No open projects
Status: ✅ Done
Status: Slipped
Development

Successfully merging a pull request may close this issue.

5 participants