-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring Windows vEthernet Adapter Networks to Properly Support Docker Container Volumes #11528
Comments
@Thraka can you take a look at this feedback? |
Hi @CyrexCore2k, thanks for the heads up! @mairaw, I just have a basic knowledge of networks, so I can't go too deep in this issue (if at all), however this seem to be related to a recurring issue we've been having in eShopOnContainers. At some point @huangmaoyixxx suggested a solution to issue #295 that seems to have worked for quite some people. However, I'm not sure the Microservices Architecture Guide is the right place to show this level of detail. Anyway I do think this would be a great topic for a page in eShopOnContainers's wiki to which we could link from the guide. @CyrexCore2k, it looks like you are knowledable in this topic, so it'd be great if you could explain this in the wiki 😊! |
Thanks @mairaw and @mvelosop for your responses. The solution suggested by @huangmaoyixxx appears to for a different issue and in the context of a non-corporate machine. Here is the situation that I'm in:
Obviously there is little/no security risk to allowing inbound connections from DockerNAT but given these five items I have not discovered a way to permanently allow inbound connections from DockerNAT. A solution which does not survive reboots is to tell Windows Firewall to consider the DockerNAT network as Private even though it is an unidentified network using the command:
While I do agree this documentation may not be the appropriate place to dig into the details of the issue this is where I ended up after a google search. Pointing to another location makes sense and while I can see how the eShopOnContainers project has run into the same thing it seems like it too would benefit from a location where this documentation can be placed. Question is, where, and who do we talk to about this? Not trying to assign blame or downplay the complexities involved but this appears to be a Windows issue. There should be a way that Docker for Windows can set up the DockerNAT network it creates so that Windows Networking can identify the network (and hence Windows Firewall would allow me to permanently specify it as a Private Network) but since I can't figure out how to do that as an Administrator of my own machine my (semi-educated) guess is that Windows Networking does not provide a way or document how to do this. I don't know enough about the internals of Microsoft to know how to facilitate getting the .Net Core / Windows Networking / Windows Firewall people and perhaps some knowledgeable Docker devs to coordinate and come to a solution. @mairaw would you be able to offer some guidance here? |
This is outside our scope. After reading through the threads (and others on Dockers site) it sounds like the problem is with Docker and Windows not playing nicely together. This isn't related to .NET at all. The main pain point sounds like you can't customize the network that docker installs because after reboot or upgrade docker reverts your changes. The problem seems to be with Docker not allowing that customization to persist. It would be nice if Docker (during setup) would ask you if you want a locked down network (public-restricted) or a developer machine network (private-unrestricted) and set the defaults for the network appropriately. If we had a tutorial that was related to a .NET Core app where we needed this network working, we would be describing the same thing: |
@Thraka |
@Thraka |
Thanks @CyrexCore2k, This is certainly a pain point for eShopOnContainer users, so I'll add this to a new networking page in the wiki. We are currently revamping the README and Wiki pages of eShop, and I'll let you know when it's public, so you can take a look and add content if you like, it'd be much appreciated. In the meantime, I'll add the PR sumbitted by @gababu with your proposal. Cheers. |
Help us make content visible
Configuring Windows vEthernet Adapter Networks to Properly Support Docker Container Volumes
Further context: docker/for-win#367 (comment)
edit by @mairaw: added article details
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: