Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change to HttpClient - EmptyContent instead of null #25953

Closed
gyphysics opened this issue Sep 3, 2021 · 1 comment
Closed

Breaking change to HttpClient - EmptyContent instead of null #25953

gyphysics opened this issue Sep 3, 2021 · 1 comment
Assignees
@gewarren
Labels
by-design dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 ⌚ Not Triaged Not triaged

Comments

@gyphysics
Copy link

Please include breaking change to the response content of HttpClient described here:

https://nicolaiarocci.com/httpresponsemessage.content-is-non-nullable-in-net5/

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Sep 3, 2021
@PRMerger17 PRMerger17 added dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 labels Sep 3, 2021
@gewarren gewarren mentioned this issue Sep 3, 2021
Merged
@gewarren gewarren self-assigned this Sep 3, 2021
@gewarren
Copy link
Contributor

gewarren commented Sep 3, 2021

@gyphysics This is actually not a breaking change, at least in the way the .NET team defines breaking changes. Please see dotnet/runtime#35910 (comment).

@gewarren gewarren closed this as completed Sep 3, 2021
@dotnet-bot dotnet-bot added ⌚ Not Triaged Not triaged and removed ⌚ Not Triaged Not triaged labels Sep 3, 2021
@gewarren gewarren added by-design and removed ⌚ Not Triaged Not triaged labels Sep 3, 2021
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gewarren gewarren

Labels
by-design dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 ⌚ Not Triaged Not triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dotnet-bot @gyphysics @gewarren @PRMerger17