New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove discussion of Task-returning non-async methods #23001

Merged

BillWagner merged 1 commit into dotnet:master from BillWagner:update-async-guidance-on-Task

Mar 3, 2021

Commits on Feb 24, 2021

remove discussion of Task-returning non-async methods

Fixes dotnet#16187

The usage of synchronous Task-returning methods is not generally recommended.  See https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task

The examples were valid, but can cause hard-to-diagnose issues.

As we add more advanced async scenarios, this scenario belongs there, with more details about when it is and isn't appropriate. (`using` in the non-async method is the primary mistake to run into).

BillWagner committed Feb 24, 2021