Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use includes for ml samples #5245

Merged
merged 6 commits into from
May 9, 2018

Conversation

BillWagner
Copy link
Member

Relies on dotnet/samples#57

@BillWagner BillWagner added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label May 8, 2018
@BillWagner BillWagner self-assigned this May 8, 2018
@BillWagner
Copy link
Member Author

closing and reopening to trigger a new build. (Samples are merged)

@BillWagner BillWagner closed this May 8, 2018
@BillWagner BillWagner reopened this May 8, 2018
const string TestDataPath = @".\Data\test.csv";
const string ModelPath = @".\Models\Model.zip";
```
[!code-csharp[InitializePaths](../../../samples/machine-learning/tutorials/SentimentAnalyis/Program.cs#2 "Define variables to store the data file paths")]
Copy link
Contributor

@pkulikov pkulikov May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and all below code snippets should link to the TaxiFarePrediction folder

@BillWagner BillWagner removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label May 9, 2018
Copy link
Contributor

@JRAlexander JRAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nit: I used "walkthrough" in an earlier version, and those need to be changed to "tutorial".

@BillWagner BillWagner merged commit 15ae51d into dotnet:master May 9, 2018
@BillWagner BillWagner deleted the use-includes-for-ml-samples branch May 9, 2018 01:45
@d4m3
Copy link

d4m3 commented May 9, 2018

Just to add, I had to change the Build Language Version to 7.1/7.2 to use with async main (wasn't listed in documentation), to make the change:
Right Click solution project > properties > Build > Advanced > Language version

@BillWagner
Copy link
Member Author

@d4m3 Thanks for pointing that out. We'll get that updated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants