Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Histogram<T> docs to note that decimal data will not be exported #10615

Open
maxs-rose opened this issue Oct 27, 2024 · 2 comments
Open
Labels
area-System.Diagnostics.Metric Pri3 Indicates issues/PRs that are low priority untriaged New issue has not been triaged by the area owner

Comments

@maxs-rose
Copy link

Describe the issue or suggestion

As per open-telemetry/opentelemetry-dotnet#5615 when creating a Histogram<decimal> the data will not acutally be exported.

Since the generic type param will accept a decimal it could be best to just add a second remark that when using it the data wont actualy be exported? Of course just removing decimal from the current list of types would also work.

Current Docs: https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.metrics.histogram-1

Happy to make a pull request doing the work however, I am not entirely sure what should be done.

@issues-automation issues-automation bot added the Pri3 Indicates issues/PRs that are low priority label Oct 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 27, 2024
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 27, 2024
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MihaZupan MihaZupan added area-System.Diagnostics.Metric and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Diagnostics.Metric Pri3 Indicates issues/PRs that are low priority untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

2 participants