Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ instrumentation #168

Open
JamesNK opened this issue Jan 29, 2024 · 0 comments
Open

RabbitMQ instrumentation #168

JamesNK opened this issue Jan 29, 2024 · 0 comments
Assignees

Comments

@JamesNK
Copy link
Member

JamesNK commented Jan 29, 2024

There is some basic instrumentation of RabbitMQ messages. However, it is missing many of the standardized tags. And the kind is wrong in some places.

e.g.

using var activity = _activitySource.StartActivity(activityName, ActivityKind.Client, parentContext.ActivityContext);
should be consumer instead of client. And I believe other client activities should be producer.

Conventions for spans:

Options available are:

  1. Improve eshop rabbitmq instrumentation.
  2. Wait for built in OTEL support in the rabbitmq library with Add OpenTelemetry support via ActivitySource rabbitmq/rabbitmq-dotnet-client#1261. Instrumentation added by eshop should be removed then.

Can do 1 and then remove with 2. Or wait for 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants