Microsoft.Data.Sqlite: Consider being strict about requiring disposal of DbCommands

[ajcvickers]

This would be a breaking change, but would have the advantage of cleaning up code like that in aspnet/Microsoft.Data.Sqlite#506.

[bricelam]

Note, we're going to make this change early in the 3.0 timeframe so customers have plenty of opportunity to provide feedback.

[jogibear9988]

What does this mean? Do we need to Dispose every Command after the change?

[bricelam]

Since DbCommand implements IDisposable, yes, they should be disposed. Unfortunately, many ADO.NET users got into the habit of not disposing of them since some popular providers don't require it. We currently compensate for this misuse by disposing of any, when disposing the connection, which haven't been finalized by the garbage collector.

[bricelam]

Removing this code could lead to more zombied connections and database files being locked longer.

[ajcvickers]

Consider guidance for other ADO.NET providers in this area. /cc @roji @divega

[bricelam]

The architecture I have in mind for #14044 will remove the need to dispose SqliteCommand objects. It will also allow them to be disposed while their SqliteDataReader is open.