Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API consistency test for conventions #20275

Open
4 tasks
Tracked by #22952
AndriySvyryd opened this issue Mar 13, 2020 · 0 comments
Open
4 tasks
Tracked by #22952

Add an API consistency test for conventions #20275

AndriySvyryd opened this issue Mar 13, 2020 · 0 comments
Assignees
Labels
area-conventions area-test punted-for-5.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-cleanup
Milestone

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Mar 13, 2020

  • Check that constructor has ProviderConventionSetBuilderDependencies and (for relational) RelationalConventionSetBuilderDependencies parameters
  • Make sure there are conventions for all events and they have the expected shape
  • Relational property, key, FK and index metadata extensions to include StoreObjectIdentifier identifier
  • Make sure ConventionSet.Add , ConventionSet.Replace and ConventionSet.Remove handle all convention types
@ajcvickers ajcvickers added this to the 5.0.0 milestone Mar 16, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, Backlog Jun 9, 2020
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, MQ Sep 4, 2020
@ajcvickers ajcvickers modified the milestones: MQ, 6.0.0 Dec 16, 2020
@ajcvickers ajcvickers modified the milestones: 6.0.0, MQ May 5, 2021
@ajcvickers ajcvickers modified the milestones: MQ, 7.0.0 Jan 21, 2022
@ajcvickers ajcvickers added the punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. label Sep 13, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, Backlog Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-conventions area-test punted-for-5.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-cleanup
Projects
None yet
Development

No branches or pull requests

2 participants