SqliteCommand allocates byte array per every query or prepare

[vonzshik]

efcore/src/Microsoft.Data.Sqlite.Core/SqliteCommand.cs

Line 475 in 9b66f4c

var sql = new byte[byteCount + 1];

I see 2 possible ways to remove this allocation:
a) ArrayPool<byte>.Shared
b) Allocate an array and keep it on bound connection

To limit the potential memory consumption after a big query there can be put a maximum limit for an array length (1mb ?), and in case of hitting it the array is allocated and dropped as it's done right now.

[roji]

This doesn't seem to escape the method, so stackalloc? Since the byteCount could be anything, we'd limit to some reasonable limit, and beyond that ArrayPool may be sufficient...

[vonzshik]

One problem with ArrayPool is that you can't control whenever it's actually going to be purged, so you may get stuck with a huge array for quite a while (see dotnet/runtime#52098, dotnet/runtime#853 and dotnet/runtime#58974 for a few other issues).

[vonzshik]

Sadly, stackalloc isn't going to cut here since you can't pass a stackalloc array to sqlite3_prepare_v2.

[bricelam]

I have bigger plans to cache the conversion to UTF8 as part of #14044