Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-deterministic tests that fail on postgres #27280

Merged
1 commit merged into from
Jan 26, 2022
Merged

Fix non-deterministic tests that fail on postgres #27280

1 commit merged into from
Jan 26, 2022

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Jan 25, 2022

Fixes #27155
Fixes #27152
Fixes #27278

@maumar maumar requested a review from roji January 25, 2022 21:57
@ghost
Copy link

ghost commented Jan 25, 2022

Hello @maumar!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@maumar maumar force-pushed the non_deterministic branch from f7b769a to 5b7744f Compare January 26, 2022 07:32
@ghost
Copy link

ghost commented Jan 26, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit afe299f into main Jan 26, 2022
@ghost ghost deleted the non_deterministic branch January 26, 2022 08:29
@roji
Copy link
Member

roji commented Jan 26, 2022

Thanks @maumar!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants