[2.0.1] Query: Fix for #9892 GroupJoin to parent with no child throws… #9982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… invalid operation exception Issue: When we are trying to lift GroupJoin queries without DefaultIfEmpty, we generate LEFT JOIN which means the inner can be null too. But we still have inner key selector doing property access on inner which could throw null ref. If the inner is using EntityShaper then shaper & all access becomes null safe, but in other cases it fails. Solution: Since inner is projecting out a non-entity, we would always have TypedProjectionShaper, which does not have null safe mechanism. Hence For such queries we need to block lifting into lift join Resolves #9892
smitpatel
commented
Oct 5, 2017
| QueryModel queryModel, | ||
| int index) | ||
| { | ||
| var additionalFromClause |
There was a problem hiding this comment.
This can be DRY with method below but for the patch I kept it separate.
maumar
approved these changes
Oct 5, 2017
| @@ -1516,6 +1516,19 @@ var innerShapedQuery | |||
| return false; | |||
| } | |||
|
|
|||
| if (!(AppContext.TryGetSwitch("Microsoft.EntityFrameworkCore.Issue9892", out var enabled) && enabled)) | |||
| { | |||
| if (!IsFlattenableGroupJoinDefaultIfEmpty(groupJoinClause, queryModel, index)) | |||
There was a problem hiding this comment.
Kept it separate intentionally.
In past @anpete raised point not to combine conditions of quirks with code so that it becomes easy to understand exact condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… invalid operation exception
Issue: When we are trying to lift GroupJoin queries without DefaultIfEmpty, we generate LEFT JOIN which means the inner can be null too. But we still have inner key selector doing property access on inner which could throw null ref. If the inner is using EntityShaper then shaper & all access becomes null safe, but in other cases it fails.
Solution: Since inner is projecting out a non-entity, we would always have TypedProjectionShaper, which does not have null safe mechanism. Hence For such queries we need to block lifting into lift join
Resolves #9892