Merge emscripten 3.1.1 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…net#837) Also, improve reporting of version resolution. e.g.: ``` $ ./emsdk install sdk-latest Resolving SDK alias 'latest' to '2.0.23' Resolving SDK version '2.0.23' to 'sdk-releases-upstream-77b065ace39e6ab21446e13f92897f956c80476a-64bit' Installing SDK 'sdk-releases-upstream-77b065ace39e6ab21446e13f92897f956c80476a-64bit'.. ... ```
Previously if a tool (any part of an SDK) was not installed we would issue a warning and continue to active without returning non-zero. This meant doing `emsdk install 2.0.0 && emsdk activate latest` would appear to be work aside from the warning messages about latest not being installed. This is especially annoying since we dropped support for side by side SDK installations. The following sequence is no longer valid and we want to make that clear by erroring out: ``` $ emsdk install 2.0.1 $ emsdk install 2.0.2 $ emsdk activate 2.0.1 ``` Since 2.0.2 replaces 2.0.1 on the filesystem the active here could fail hard rather than just warning.
This should help debug cases when the link_wrapper is not invoked correctly.
When linking with `-o filename` (such as in various CMake build checks), the parameter passed to the linker is a temporary file, and it is passed as a bare filename (i.e. relative path without a `'/'`). In such cases, `outdir` would have been the empty string, and the final `tar` command would fail (actually the call to `subprocess.check_call(…)` is what fails).
Includes LTO and non-LTO, with non-LTO as the default
In the past the instructions were to copy `emscripten_toolchain` into the project dir, now it downloads emsdk as a package so the `bazelrc` part has to refer to `@emsdk`.
This was missing from emsdk_manifest.json and should alow older fastcomp SDKs to be install on M1 apple hardware (in emulation mode). Fixes: dotnet#889
Make untargz() in emsdk.py return False if tar command failed.
…ant to see double quotes in the field passed to it. (dotnet#898)
* Add embind example to Bazel docs * address feedback
* Update build_bazel_rules_nodejs to fix closure compiles * Fix spacing in update_bazel_workspace.sh script * space
* Always output a tarball from cc_binary to simplify logic. This will change the result of --config=wasm builds that were previously outputting a single file. * better to use early return here * Always output a tarball from cc_binary to simplify logic. This will change the result of --config=wasm builds that were previously outputting a single file. * better to use early return here Co-authored-by: Mitch Foley <mitchfoley@chromium.org>
Prevent downloading the tool archives all over again, if you switch some emscripten or tool version.
I'm not sure how that wrong was added by the create_release script.
Followup to dotnet#930: Add a tests, and remove newly-unused arguments to unzip and untargz.
When invoking "emsdk help", there is a typo/grammatical error in the second to last paragraph.
See also:
emscripten-core#957
The usage of this argument was removed in dotnet#838.
The newer versions of eslint require 14.17.0 or above. This updates our node version to the latest in the 14.XX series. I don't expect any user-visible changes.
This reverts commit b581f08.
|
It should be merged or rebased without squashing, to allow smooth merge of upstream in future. |
|
Lets get links to the staged prs in dotnet/icu and dotnet/runtime here then we can try rolling forward |
|
dotnet/icu PR: dotnet/icu#183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also revert 2.0.34 commit as it was squashed by mistake and re-merge the 2.0.34 PR branch again, before merging 3.1.1