Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance on mixing Extensions versions vs .Net Core version #2799

Closed
czb182 opened this issue Dec 21, 2019 · 5 comments
Closed

Guidance on mixing Extensions versions vs .Net Core version #2799

czb182 opened this issue Dec 21, 2019 · 5 comments
Milestone

Comments

@czb182
Copy link

czb182 commented Dec 21, 2019

Scenario. Targeting .NET core 2.1, netstandard2.0 running on .NET core 2.1. We are leveraging ASP.NET core (which would be 2.1 since part of core). We consume many packages from this repo and they are versioned the same as .NET core. I get many Nuget updates available for 2.2, 3.0, 3.1 versions of these packages and I'm not sure if can upgrade to any safely. Am I supposed to stay on 2.1.* versions of these packages? Are only the 2.1.* and 3.1.* versions of these packages considered 'LTS' or is this repo out of that scope?

I searched a while trying to find guidance on this, but was unable to, so hoping someone can point to some documentation or have some written. This seems like an obvious question, so surprised I couldn't find anything. I'm tempted to use wildcard versions (2.1.*) but not sure if necessary.

@Pilchie
Copy link
Member

Pilchie commented Dec 23, 2019

Tagging @DamianEdwards and @ChrisSfanos about published guidance.

The short answer is you should match the major/minor of the ASP.NET Core version you are running, and yes, the LTS version match up with the rest of the .NET Core versions.

@Pilchie Pilchie closed this as completed Dec 23, 2019
@Pilchie Pilchie reopened this Dec 23, 2019
@Pilchie
Copy link
Member

Pilchie commented Dec 23, 2019

Didn't mean to close without a chance to get some published guidance.

@czb182
Copy link
Author

czb182 commented Jan 10, 2020

seems like this version consistency should be loosely enforced somehow. We are not directly referencing asp.net core, but rather target Microsoft.NET.Sdk.Web SDK which implicity references Microsoft.AspNetCore.App according to https://docs.microsoft.com/en-us/aspnet/core/fundamentals/metapackage-app?view=aspnetcore-3.1

Since no versions of asp.net core are mentioned explicitly, would need to infer from TargetFramework I think. So if targeting netcoreapp2.1 should make sure all the asp.net references falling within 2.1.*. Could use this to avoid suggesting updates for these dependencies since they are not recommended from your above comment.

@czb182
Copy link
Author

czb182 commented Jan 31, 2020

any updates on this? specifcally how one should go about locking to a specific version of aspnetcore/core that we are targeting(in our case 2.1 LTS)

@Pilchie
Copy link
Member

Pilchie commented Jan 31, 2020

We don't really have a tooled way of doing this - people normally just manage their versions themselves. You could consider doing in MSBuild based on some property like $(TargetFrameworkVersion) though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants