Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve CS0104: 'OptionsValidator' is an ambiguous reference between 'Microsoft.Extensions.Options.OptionsValidatorAttribute' and 'Microsoft.Extensions.Options.Validation.OptionsValidatorAttribute' #4117

Closed
RussKie opened this issue Jun 26, 2023 · 5 comments
Closed

Resolve CS0104: 'OptionsValidator' is an ambiguous reference between 'Microsoft.Extensions.Options.OptionsValidatorAttribute' and 'Microsoft.Extensions.Options.Validation.OptionsValidatorAttribute' #4117

RussKie opened this issue Jun 26, 2023 · 5 comments
Assignees
@geeknoid

Comments

@RussKie
Copy link
Member

RussKie commented Jun 26, 2023 •
edited
Loading

dotnet/runtime#87587 appears to implement the same functionality as currently provided https://github.com/dotnet/extensions/tree/main/src/Libraries/Microsoft.Extensions.Options.Validation.

See #4101.
@RussKie
Copy link
Member Author

RussKie commented Jun 26, 2023

@geeknoid assigning to you

@RussKie
Copy link
Member Author

RussKie commented Jun 26, 2023

It appears dotnet/runtime#87587 made into Preview6 branch, thus blocking #4101 (and #4107).

@geeknoid
Copy link
Member

@RussKie So how should I address this? Should I add a commit to #4101 that removes the dotnet/extensions validation code generator?

@RussKie
Copy link
Member Author

RussKie commented Jun 26, 2023

Should I add a commit to #4101 that removes the dotnet/extensions validation code generator?

Yes, please pile on top of #4101. Then we can port the changes to the main branch as well.

@RussKie
Copy link
Member Author

RussKie commented Jun 28, 2023

Resolved in #4129

@RussKie RussKie closed this as completed Jun 28, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@geeknoid geeknoid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RussKie @geeknoid