Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect and superfluous parameter hints in methods with optional parameters #14459

Closed
0101 opened this issue Dec 8, 2022 · 1 comment
Closed

Incorrect and superfluous parameter hints in methods with optional parameters #14459

0101 opened this issue Dec 8, 2022 · 1 comment
Assignees
@psfinaki
Labels
Area-LangService-Hints F# hints inspired by C# inline hints Bug good first issue Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Milestone
Backlog

Comments

@0101
Copy link
Contributor

0101 commented Dec 8, 2022

image

type MyType() =

    member _.MyMethod(?beep: int, ?bap: int, ?boop: int) = ()

    member this.Foo = this.MyMethod(bap = 3, boop = 4)

Since parameters can be optional not all of them need to be present and they can be out of order. Also, if I'm already specifying them explicitly there's no need to also show hints.

Also in the method definition, hints are shown even when types are specified which is questionable.
@0101 0101 added Bug Needs-Triage Area-LangService-Hints F# hints inspired by C# inline hints labels Dec 8, 2022
@github-actions github-actions bot added this to the Backlog milestone Dec 8, 2022
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Dec 8, 2022
@0101 0101 mentioned this issue Dec 8, 2022
Open
@T-Gro T-Gro added Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. and removed Needs-Triage labels Dec 12, 2022
@psfinaki psfinaki self-assigned this Dec 20, 2022
@psfinaki psfinaki mentioned this issue Dec 20, 2022
Merged
@psfinaki
Copy link
Member

Not closing yet, because there is also a type hint issue.

@rosskuehl rosskuehl mentioned this issue Dec 29, 2022
Merged
@psfinaki psfinaki closed this as completed Jan 5, 2023
@github-project-automation github-project-automation bot moved this from Not Planned to Done in F# Compiler and Tooling Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psfinaki psfinaki

Labels
Area-LangService-Hints F# hints inspired by C# inline hints Bug good first issue Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

No branches or pull requests
3 participants
@0101 @psfinaki @T-Gro