Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor new properties on ObsoleteAttribute for .NET 5 #8654

Open
cartermp opened this issue Mar 3, 2020 · 3 comments
Open

Honor new properties on ObsoleteAttribute for .NET 5 #8654

cartermp opened this issue Mar 3, 2020 · 3 comments
Labels
Area-Compiler-Checking Type checking, attributes and all aspects of logic checking Feature Request
Milestone

Comments

@cartermp
Copy link
Contributor

cartermp commented Mar 3, 2020

See corresponding Roslyn issue here: dotnet/roslyn#42119

namespace System
{
    public partial class ObsoleteAttribute : Attribute
    {
        // Existing:
        //
        // public ObsoleteAttribute();
        // public ObsoleteAttribute(string message);
        // public ObsoleteAttribute(string message, bool error);
        // public bool IsError { get; }
        // public string Message { get; }

        // New:
        public string DiagnosticId { get; set; }
        public string UrlFormat { get; set; }
    }
}

Handling of these properties is covered in the spec here: https://github.com/dotnet/designs/blob/master/accepted/2020/better-obsoletion/better-obsoletion.md#api-changes

The code to update is here:

let private CheckILAttributes (g: TcGlobals) isByrefLikeTyconRef cattrs m =

Tagging @terrajobst

@abelbraaksma

This comment has been minimized.

@abelbraaksma

This comment has been minimized.

@terrajobst

This comment has been minimized.

@dsyme dsyme added the Area-Compiler-Checking Type checking, attributes and all aspects of logic checking label Apr 21, 2022
@T-Gro T-Gro self-assigned this Dec 22, 2022
@T-Gro T-Gro removed their assignment May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compiler-Checking Type checking, attributes and all aspects of logic checking Feature Request
Projects
Status: New
Development

No branches or pull requests

5 participants