Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review warning messages and messages in attributes #1275

Closed
vitek-karas opened this issue Jun 16, 2020 · 4 comments
Closed

Review warning messages and messages in attributes #1275

vitek-karas opened this issue Jun 16, 2020 · 4 comments
Labels
area-Linker: Diagnostic

Comments

@vitek-karas
Copy link
Member

Warning messages specifically around data flow analysis and trim correctness seem to be all over the place in terms of quality. Native English speaker should review these to make sure it makes sense and sounds like english.
@vitek-karas vitek-karas added this to the .NET5.0 milestone Jun 16, 2020
@vitek-karas vitek-karas mentioned this issue Jun 16, 2020
Merged
@marek-safar
Copy link
Contributor

Do we have any candidate who could help us with that?

@stephentoub for ideas ;-)

@vitek-karas
Copy link
Member Author

I was planning to sign up @samsp-msft for this 😄

@stephentoub
Copy link
Member

I can help if Sam can't.

@mateoatr mateoatr mentioned this issue Jun 29, 2020
Closed
@marek-safar marek-safar removed this from the .NET 5.0 milestone Sep 24, 2020
@vitek-karas
Copy link
Member Author

This was done by Sam quite a while ago. That doesn't mean the messages can't be improved, but at least they should read as English right now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Linker: Diagnostic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marek-safar @stephentoub @vitek-karas