Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The same assembly is loaded multiple times if it passed as multiple --custom-step arguments #1314

Closed
rolfbjarne opened this issue Jul 6, 2020 · 1 comment · Fixed by #2019
Closed

The same assembly is loaded multiple times if it passed as multiple --custom-step arguments #1314

rolfbjarne opened this issue Jul 6, 2020 · 1 comment · Fixed by #2019
Labels
area-Linker: Extensibility
Milestone
6.0.x

Comments

@rolfbjarne
Copy link
Member

The same assembly is loaded once for each --custom-step argument.

My guess is because it's loaded using the Assembly.Load(byte[]) overload: https://github.com/mono/linker/blob/da2cc0fcd6c3a8e8e5d1b5d4a655f3653baa8980/src/linker/Linker/Driver.cs#L723

This is quite confusing if you have static state in one step you expect to be around in subsequent steps (it also means that if I want to share state between steps, I have to resort to ugly workarounds.
@rolfbjarne rolfbjarne mentioned this issue Jul 6, 2020
Closed
61 tasks
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jul 23, 2020
@rolfbjarne
[dotnet] Only pass a single custom step to the linker.
6b066e0 
The linker will load the assemblies with the custom steps once per custom step
argument, which means that each step is effectively in a different assembly,
making it impossible to share state between steps.

This behavior is filed as a linker bug: dotnet/linker#1314

Until this is fixed, we can just have a single step that injects all the other
steps programmatically.
@rolfbjarne rolfbjarne mentioned this issue Jul 23, 2020
Merged
rolfbjarne added a commit to xamarin/xamarin-macios that referenced this issue Jul 24, 2020
@rolfbjarne
[dotnet] Only pass a single custom step to the linker. (#9173)
4a5dc20 
* [dotnet] Only pass a single custom step to the linker.

The linker will load the assemblies with the custom steps once per custom step
argument, which means that each step is effectively in a different assembly,
making it impossible to share state between steps.

This behavior is filed as a linker bug: dotnet/linker#1314

Until this is fixed, we can just have a single step that injects all the other
steps programmatically.

* [tests] Adjust .NET tests according to new behavior.
@rolfbjarne
Copy link
Member Author

rolfbjarne commented Aug 20, 2020 •
edited
Loading

Another effect of loading the custom step assembly as a byte array is that no debug information will be loaded, so stack traces won't include source code information (not even if the embedding the debug information in the dll), and neither is it possible to debug using VSCode.

@marek-safar marek-safar added this to the .NET 6.0 milestone Nov 10, 2020
This was referenced Apr 9, 2021
Merged
Closed
@rolfbjarne rolfbjarne mentioned this issue Apr 30, 2021
Merged
@sbomer sbomer mentioned this issue May 7, 2021
Merged
@rolfbjarne rolfbjarne mentioned this issue Sep 8, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Linker: Extensibility
Projects
None yet
Milestone
6.0.x
Development

Successfully merging a pull request may close this issue.

Allow custom steps to share state sbomer/linker
2 participants
@rolfbjarne @marek-safar