Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to generate the suppressions in the linker attribute XML format #1380

Closed
vitek-karas opened this issue Jul 22, 2020 · 0 comments
Assignees
Milestone

Comments

@vitek-karas
Copy link
Member

Currently the --generate-warning-suppressions will produce the suppressions in C# - as a C# source code using the attribute syntax. This is useful if I want to make the suppressions part of my shipping code (as I include the source file with my project), but it's not useful if I only want to use the suppressions within the build system of my project, but not include the suppressions in the final bits.

One way to do the latter would be to produce the suppressions in the XML format, and only pass them as a command line for the linker - for that invocation of the linker those suppressions would take effect, but they would not get baked into the final build.

See dotnet/runtime#39133 for detailed discussion why this is an issue in the dotnet/runtime repo

As a technical solution, we could change the --generate-warning-suppressions option to take a value (not just true/false) - so basically either --generate-warning-suppressions cs or --generate-warning-suppressions xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants