Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the netcoreapp3.0 build is broken #1495

Closed
eerhardt opened this issue Nov 1, 2018 · 2 comments
Closed

the netcoreapp3.0 build is broken #1495

eerhardt opened this issue Nov 1, 2018 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@eerhardt
Copy link
Member

eerhardt commented Nov 1, 2018

Follow the instructions: https://github.com/dotnet/machinelearning/blob/master/docs/building/netcoreapp3.0-instructions.md

You will get a build error:

Error	CS0266	Cannot implicitly convert type 'float*' to 'int'. An explicit conversion exists (are you missing a cast?)	Microsoft.ML.CpuMath(netcoreapp3.0)	F:\git\machinelearning2\src\Microsoft.ML.CpuMath\SseIntrinsics.cs	758	Active

This is because of #1177

                float* pDstEnd = pdst + dst.Length;
                float* pDstCurrent = pdst;
                int destinationEnd = pDstEnd - 4;

pDstEnd is a float*. Subtracting 4 still gives you a float*, which is not convertable to int.

/cc @jwood803 @tannergooding

@jwood803
Copy link
Contributor

jwood803 commented Nov 1, 2018

@eerhardt Whoops! Sorry about that! I'll get this fixed.

@shauheen shauheen added this to the 1118 milestone Nov 1, 2018
@shauheen shauheen added the bug Something isn't working label Nov 1, 2018
@eerhardt
Copy link
Member Author

eerhardt commented Nov 5, 2018

Resolved by #1497

@eerhardt eerhardt closed this as completed Nov 5, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants