Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueMappingEstimator in the Conversions catalog is missing the treatAsKeys parameter #2346

Closed
singlis opened this issue Jan 31, 2019 · 2 comments
Assignees

Comments

@singlis
Copy link
Member

singlis commented Jan 31, 2019

When adding samples, I noticed that the treatValuesAsKeys parameter is not available as part of the Conversions catalog. Therefore I am not able to do this:

         var pipeline = ml.Transforms.Conversions.ValueMap(educationKeys, educationValues, true, ("EducationKeyType", "Education"));

And instead have to do this:

            var pipeline = new ValueMappingEstimator<string, string>(ml, educationKeys, educationValues, true, ("EducationKeyType", "Education"));

Therefore we should add another function to the Conversions Catalog to handle this.

@Ivanidzo4ka
Copy link
Contributor

Is it still relevant? If yes, would you have time to fix it?

@singlis
Copy link
Member Author

singlis commented Apr 1, 2019

Note this was added by @artidoro, #2959

@singlis singlis closed this as completed Apr 1, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants