Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberOfIterations vs. MaxIterations #2871

Closed
rogancarr opened this issue Mar 6, 2019 · 2 comments
Closed

NumberOfIterations vs. MaxIterations #2871

rogancarr opened this issue Mar 6, 2019 · 2 comments
Assignees
@rogancarr
Labels
API Issues pertaining the friendly API
Milestone
0319

Comments

@rogancarr
Copy link
Contributor

rogancarr commented Mar 6, 2019 •
edited
Loading

The recent naming changes to K-Means and SDCA (and perhaps others?) resulted in MaxIterations being renamed to NumberOfIterations. Since this parameter specifies the worst-case bound and not the actual number of iterations taken in most cases, I think we should keep it named MaxIterations.

Whatever we call it, NumberOfIterations is not what this parameter specifies — this is a stopping criterion, not a guaranteed execution parameter.
@rogancarr rogancarr added the API Issues pertaining the friendly API label Mar 6, 2019
@rogancarr rogancarr changed the title k-means NumberOfIterations NumberOfIterations vs. MaxIterations Mar 6, 2019
@wschin
Copy link
Member

wschin commented Mar 6, 2019

Maybe MaximumNumberOfIteration or MaximumIterationCount?

@rogancarr
Copy link
Contributor Author

MaximumNumberOfIterations

@rogancarr rogancarr self-assigned this Mar 7, 2019
@rogancarr rogancarr mentioned this issue Mar 7, 2019
Merged
@shauheen shauheen added this to the 0319 milestone Mar 7, 2019
@rogancarr rogancarr mentioned this issue Mar 12, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rogancarr rogancarr

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0319
Development

No branches or pull requests
3 participants
@shauheen @wschin @rogancarr