Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplyOnnxModel API parameters are in the wrong order #3082

Closed
rogancarr opened this issue Mar 25, 2019 · 0 comments
Closed

ApplyOnnxModel API parameters are in the wrong order #3082

rogancarr opened this issue Mar 25, 2019 · 0 comments
Assignees
Labels
API Issues pertaining the friendly API
Milestone

Comments

@rogancarr
Copy link
Contributor

The ApplyOnnxModel Transformer has a parameter order based on the ONNX model (see below) but as a Transformer, it should have parameters ordered to reflect the modification of the input IDataView.

Here is the current API:

public static OnnxScoringEstimator ApplyOnnxModel(this TransformsCatalog catalog,
            string modelFile,
            string outputColumnName,
            string inputColumnName,
            int? gpuDeviceId = null,
            bool fallbackToCpu = false);

This should be re-ordered to be:

public static OnnxScoringEstimator ApplyOnnxModel(this TransformsCatalog catalog,
            string outputColumnName,
            string inputColumnName,
            string modelFile,
            int? gpuDeviceId = null,
            bool fallbackToCpu = false);

Related to #3079

@rogancarr rogancarr added the API Issues pertaining the friendly API label Mar 25, 2019
@rogancarr rogancarr self-assigned this Mar 25, 2019
@shauheen shauheen added this to the 0319 milestone Mar 26, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

No branches or pull requests

2 participants