Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample for use with Binary dataset #3748

Closed
PeterPann23 opened this issue May 20, 2019 · 7 comments
Closed

Add sample for use with Binary dataset #3748

PeterPann23 opened this issue May 20, 2019 · 7 comments

Comments

@PeterPann23
Copy link

[Enter feedback here]

Would be nice to show how a binary file can be used (and re-used) to use strong typed data

Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@CESARDELATORRE
Copy link
Contributor

@PeterPann23 - Can you clarify what do you mean with a 'binary file'?
Do you mean an IDV dataset? (.IDV is the IDataView proprietary serialization format).

Or do you mean a different kind of binary file?

Thanks,
Cesar

@PeterPann23
Copy link
Author

Yes, yes I do, there is a convention to call/ save it using .idv extension, however
this suggestion is not written anywhere in the the code comments and the methods are called
mlContext.Data.SaveAsBinary(dataView, fileName);
mlContext.Data.LoadFromBinary(fileName);

so to call it binary or to call "Internal Data View" or what does it stand for...

@CESARDELATORRE
Copy link
Contributor

@PeterPann23 - I agree. This should also be in the docs.microsoft.com pages.
I just created another issue in there related to this:

dotnet/docs#12451

@najeeb-kazmi
Copy link
Member

@CESARDELATORRE @PeterPann23 is this related to #3661 ? I have a PR #3745 out that adds a sample for Binary load/save, as well as Text load/save.

@CESARDELATORRE
Copy link
Contributor

@najeeb-kazmi - Yep! Completely related! That PR is great to have.
But we should also document it in a more "tutorial" approach at docs.microsoft.com so that's why I opened another issue at docs.microsoft.com

Thanks Najeeb! 👍

@najeeb-kazmi
Copy link
Member

@CESARDELATORRE @PeterPann23 - Shall we close this issue then, since it's covered by the PR on the ML.NET side, and we have another issue to track the tutorial on docs.microsoft.com?

@abgoswam
Copy link
Member

Closing this issue . PR #3745 addresses this

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants