Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CpuMath Enhancement: Add unit tests for software fallbacks of hardware intrinsics #834

Closed
briancylui opened this issue Sep 5, 2018 · 2 comments

Comments

@briancylui
Copy link
Contributor

Style changes needed to solve part of #823

Details

  • Add unit tests for software fallback implementations, particularly for MatTimesSrc.

Reference:

  • The software fallback implementations are in src\Microsoft.ML.CpuMath\CpuMathUtils.netcoreapp.cs, encapsulated in the following switching paradigm:
if (Avx.IsSupported)
{
    // AvxIntrinsics
}
else if (Sse.IsSupported)
{
    // SseIntrinsics
}
else
{
    // Software fallback
}
  • Unit tests are implemented in test\Microsoft.ML.CpuMath.UnitTests.netcoreapp/UnitTests.cs
  • To turn on the software fallback implementation in unit tests, you may have to turn off the environment variable COMPlus_FeatureSimd.
@briancylui briancylui changed the title Add unit tests for software fallbacks of hardware intrinsics CpuMath Enhancement: Add unit tests for software fallbacks of hardware intrinsics Sep 6, 2018
@danmoseley
Copy link
Member

Covered by #1156

@danmoseley
Copy link
Member

Covered by #1156

@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants