CollectionView Items display issue when Header is resized on iOS #21812

kubaflo · 2024-04-13T15:23:59Z

Issues Fixed

Fixes #20538
Fixes #12429

Before	After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-13.at.17.21.10.mp4	Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-13.at.17.17.05.mp4

PureWeen · 2024-04-15T06:52:29Z

src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs

@@ -46,6 +46,16 @@ protected override void Dispose(bool disposing)
 					_footerViewFormsElement.MeasureInvalidated -= OnFormsElementMeasureInvalidated;
 				}

+				if (_headerUIView is MauiView hv)
+				{
+					hv.LayoutChanged += HeaderView_LayoutChanged;


What if you subscribe to SizeChanged on the header/footer xplat elements?

When I try to do the following:
_headerViewFormsElement.SizeChanged += _headerViewFormsElement_SizeChanged;

_headerViewFormsElement_SizeChanged never triggers

src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs

rmarinho · 2024-04-20T09:47:43Z

/azp run

azure-pipelines · 2024-04-20T09:48:02Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-04-22T13:24:42Z

/azp run

azure-pipelines · 2024-04-22T13:25:03Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-05-09T11:48:07Z

/azp run

azure-pipelines · 2024-05-09T11:48:28Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-06-10T14:13:10Z

/azp run

azure-pipelines · 2024-06-10T14:13:31Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Core/src/Platform/iOS/MauiView.cs

mattleibow

I am just wondering about the fact that now we have 2 events that are triggering the layout code when the first did not work. Is there a reason for both?

mattleibow · 2024-07-18T19:02:20Z

src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs

+				if (_headerUIView is MauiView hv)
+				{
+					hv.LayoutChanged -= HeaderViewLayoutChanged;
+				}


If we are now watching the actual method that is doing layout, do we still need the original _footerViewFormsElement.MeasureInvalidated? The code seems to end up calling the same HandleFormsElementMeasureInvalidated method.

IS grabbing the element for footer and header not the all view right? some still need for each one .

mattleibow · 2024-07-18T19:05:42Z

src/Core/src/Platform/iOS/MauiView.cs

@@ -134,6 +134,7 @@ public override void LayoutSubviews()
 			}

 			CrossPlatformArrange(bounds);
+			OnLayoutChanged();


Maybe this should be renamed to match the method. Also, no need to have the method, just invoke the event directly. Maybe use a name of ArrangingSubviews or even just OnLayoutSubviews since it is internal. I see MovedToWindow got away with the same name because it was an explicit interface member.

I changed it to invoke the event directly

PureWeen

We should revisit if this is needed once we test on net9 with CollectionViewHandler2 and once we merge this PR #23052

rmarinho · 2024-10-10T14:42:59Z

/rebase

rmarinho · 2024-10-10T14:47:56Z

/azp run

azure-pipelines · 2024-10-10T14:48:17Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-10-31T11:56:12Z

@kubaflo Could you rebase and fix the conflicts? Thanks in advance.

kubaflo · 2024-11-15T01:26:09Z

We should revisit if this is needed once we test on net9 with CollectionViewHandler2 and once we merge this PR #23052

@PureWeen you were right!
But I think we can include the UI test from this PR. What do you think?

rmarinho · 2024-12-09T11:34:56Z

/rebase

rmarinho · 2024-12-11T10:27:22Z

/rebase

rmarinho · 2024-12-11T10:28:30Z

/azp run

azure-pipelines · 2024-12-11T10:28:50Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Core/src/Platform/iOS/MauiView.cs

rmarinho · 2024-12-16T11:37:14Z

/azp run

azure-pipelines · 2024-12-16T11:37:34Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-12-16T11:46:11Z

/azp run

azure-pipelines · 2024-12-16T11:46:32Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-12-17T17:33:22Z

/azp run

kubaflo · 2024-12-17T17:33:26Z

@rmarinho it turned out that I had to make some changes to fix it. So, it is not only a UI test now

azure-pipelines · 2024-12-17T17:33:45Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-12-17T18:56:56Z

Seems is failing for CV2

kubaflo · 2024-12-17T19:05:38Z

@rmarinho Luckily, it is only because the iOS screenshot needs to be updated. Could you please /azp?

rmarinho · 2024-12-18T11:35:02Z

/azp run

azure-pipelines · 2024-12-18T11:35:23Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho

Seems the tests are failing for CV2 HeaderShouldNotCollapseWithItems

kubaflo · 2024-12-19T13:55:01Z

@rmarinho hmm, locally it works well with the following change:

Maybe let's try run tests again

kubaflo requested a review from a team as a code owner April 13, 2024 15:23

kubaflo requested review from StephaneDelcroix and jfversluis April 13, 2024 15:24

dotnet-policy-service bot added the community ✨ Community Contribution label Apr 13, 2024

PureWeen reviewed Apr 15, 2024

View reviewed changes

jsuarezruiz added platform/iOS 🍎 area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Apr 15, 2024

kubaflo force-pushed the fix-12429 branch from 16cce68 to fa70317 Compare April 15, 2024 18:27

rmarinho reviewed Apr 19, 2024

View reviewed changes

src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs Outdated Show resolved Hide resolved

dotnet deleted a comment from azure-pipelines bot Jun 12, 2024

jsuarezruiz reviewed Jun 12, 2024

View reviewed changes

src/Core/src/Platform/iOS/MauiView.cs Outdated Show resolved Hide resolved

mattleibow reviewed Jul 18, 2024

View reviewed changes

kubaflo force-pushed the fix-12429 branch from f5c4179 to e8da440 Compare July 19, 2024 23:02

PureWeen requested changes Aug 3, 2024

View reviewed changes

github-actions bot force-pushed the fix-12429 branch from e8da440 to 718e416 Compare October 10, 2024 14:43

kubaflo force-pushed the fix-12429 branch from 718e416 to 8d7d563 Compare October 11, 2024 13:10

kubaflo changed the title ~~CollectionView Items display issue when Header is resized on iOS - Fix~~ CollectionView Items display issue when Header is resized on iOS - UI-Test Oct 31, 2024

github-actions bot force-pushed the fix-12429 branch from 42f825d to fd0be1e Compare December 9, 2024 11:35

github-actions bot force-pushed the fix-12429 branch from fd0be1e to b1a14d2 Compare December 11, 2024 10:27

dotnet deleted a comment from azure-pipelines bot Dec 11, 2024

rmarinho force-pushed the fix-12429 branch from b1a14d2 to 3118af3 Compare December 16, 2024 11:28

rmarinho reviewed Dec 16, 2024

View reviewed changes

src/Core/src/Platform/iOS/MauiView.cs Show resolved Hide resolved

kubaflo force-pushed the fix-12429 branch from 3118af3 to f61175d Compare December 16, 2024 11:42

kubaflo force-pushed the fix-12429 branch from f61175d to 94e7c18 Compare December 17, 2024 17:32

kubaflo changed the title ~~CollectionView Items display issue when Header is resized on iOS - UI-Test~~ CollectionView Items display issue when Header is resized on iOS Dec 17, 2024

kubaflo force-pushed the fix-12429 branch from ea608aa to 4b441e1 Compare December 18, 2024 00:32

rmarinho requested changes Dec 18, 2024

View reviewed changes

CollectionView Items display issue when Header is resized on iOS

23d1b2d

kubaflo force-pushed the fix-12429 branch from 4b441e1 to 23d1b2d Compare December 19, 2024 13:55

CollectionView Items display issue when Header is resized on iOS #21812

Are you sure you want to change the base?

CollectionView Items display issue when Header is resized on iOS #21812

Conversation

kubaflo commented Apr 13, 2024

Issues Fixed

PureWeen Apr 15, 2024

Choose a reason for hiding this comment

kubaflo Apr 15, 2024

Choose a reason for hiding this comment

rmarinho commented Apr 20, 2024

azure-pipelines bot commented Apr 20, 2024

rmarinho commented Apr 22, 2024

azure-pipelines bot commented Apr 22, 2024

jsuarezruiz commented May 9, 2024

azure-pipelines bot commented May 9, 2024

jsuarezruiz commented Jun 10, 2024

azure-pipelines bot commented Jun 10, 2024

mattleibow left a comment

Choose a reason for hiding this comment

mattleibow Jul 18, 2024

Choose a reason for hiding this comment

rmarinho Jul 19, 2024

Choose a reason for hiding this comment

mattleibow Jul 18, 2024

Choose a reason for hiding this comment

kubaflo Jul 19, 2024 • edited Loading

Choose a reason for hiding this comment

PureWeen left a comment

Choose a reason for hiding this comment

rmarinho commented Oct 10, 2024

rmarinho commented Oct 10, 2024

azure-pipelines bot commented Oct 10, 2024

jsuarezruiz commented Oct 31, 2024

kubaflo commented Nov 15, 2024

rmarinho commented Dec 9, 2024

rmarinho commented Dec 11, 2024

rmarinho commented Dec 11, 2024

azure-pipelines bot commented Dec 11, 2024

rmarinho commented Dec 16, 2024

azure-pipelines bot commented Dec 16, 2024

rmarinho commented Dec 16, 2024

azure-pipelines bot commented Dec 16, 2024

rmarinho commented Dec 17, 2024

kubaflo commented Dec 17, 2024

azure-pipelines bot commented Dec 17, 2024

rmarinho commented Dec 17, 2024

kubaflo commented Dec 17, 2024 • edited Loading

rmarinho commented Dec 18, 2024

azure-pipelines bot commented Dec 18, 2024

rmarinho left a comment

Choose a reason for hiding this comment

kubaflo commented Dec 19, 2024

kubaflo Jul 19, 2024 •

edited

Loading

kubaflo commented Dec 17, 2024 •

edited

Loading